Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

Fix contrib.boolean_mask for 0-size output #15731

Merged
merged 1 commit into from
Aug 2, 2019

Conversation

haojin2
Copy link
Contributor

@haojin2 haojin2 commented Aug 2, 2019

Description

As title.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [MXNET-$JIRA_ID], where $JIRA_ID refers to the relevant JIRA issue created (except PRs with tiny changes)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

  • Add extra handling for 0-size output from contrib.boolean_mask
  • Corresponding unit test case

Comments

@haojin2 haojin2 requested a review from reminisce August 2, 2019 00:56
@haojin2 haojin2 self-assigned this Aug 2, 2019
@haojin2 haojin2 added Bug pr-awaiting-review PR is waiting for code review labels Aug 2, 2019
@reminisce reminisce merged commit 87425d2 into apache:master Aug 2, 2019
@haojin2 haojin2 deleted the boolean_mask_0_size branch August 2, 2019 18:58
anirudhacharya pushed a commit to anirudhacharya/mxnet that referenced this pull request Aug 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants